feat: support for q/kdb programming language #13936
Conversation
Additionally, make it possible for quarto to read percent style notebooks from languages that don't use `#` as the comment char
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
benlubas
changed the title
|
I've also been able to add q syntax highlighting by adding these two files to I'm not sure that jives with the agreement that you made me sign in order to contribute, but you're already doing it, so it seems okay? |
|
Thanks for the PR!
I think the CLA we have covers that, yes. I'll send a review along. If you were only adding the extensions to the list as well as the Kate files, I'd be willing to merge it without tests. But you've added a new feature (which is great!), and so that means we need to make sure we're not breaking anything now or in the future. One added complication is that I'm not sure that I want to have our CI install the q/kdb jupyter kernel. I have to think about this a little bit. |
cscheid
left a comment
cscheid
left a comment
There was a problem hiding this comment.
Are you sure it's ok to change the comment syntax from jupyter percent scripts?
This appears to imply it's not: https://jupytext.readthedocs.io/en/latest/formats-scripts.html
Yes, I think so. Jupytext supports other languages and other comment strings. here is the source code: https://github.com/mwouts/jupytext/blob/main/src%2Fjupytext%2Flanguages.py#L52 |
|
I have a number of fixes/suggestions here that I'm going to push to this PR. Stand by for a couple of hours - thanks! |
- Add comprehensive unit tests for percent format notebook parsing - Test detection and conversion for Python, Julia, R, and q languages - Fix isJupyterPercentScript regex: properly group alternation (markdown|raw) and use multiline mode so ^ matches start of any line - Add changelog entries for q/kdb+ support and regex fix Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Ok, the fixes are there. Let's see what the CI says now. |
|
You're too kind! I hope you don't feel the need to do this for all of my PRs, I don't want to create a ton of extra work 😅 |
Thanks for the kind words. My answer would have been different 6 months ago, but now I have a hungry ghost on my side that likes to write TS code, it turns out! This looks good to me now, but I've been far from quarto-cli for the last couple of months, so I'll let someone else press the final merge button. |
3 participants
weird company behavior
Welcome to the quarto GitHub repo!
We are always happy to hear feedback from our users.
To file a pull request, please follow these instructions carefully: https://yihui.org/issue/#bug-reports
If you're a collaborator from outside
quarto-devmaking changes larger than a typo, please make sure you have filed an individual or corporate contributor agreement. You can send the signed copy to jj@rstudio.com.Description
Adding support for the q/kdb programming language in two ways:
/)#, and of course adding support for qAddresses #12168
Part of #13946
Checklist
I have (if applicable):
I'm a new contributor, please point me in the direction of any tests you need me to add/documentation you need me to write.